Green is always connected to the field ("F" terminal) on the dynamo, yellow to the "D" terminal.
Those wire colours in the loom sound totally wrong to me. Essentially you need to take the live feed from the regulator to one side of the ammeter (and the feed for the lights etc are also connected here) and the battery live to the other. However, feed to the horn and stoplight switch are normally taken from the battery side so as not to give confusing ammeter readings.
You need to make sure the polarity of the dynamo corresponds to that of the battery. ISTR you're dealing with a 50s BSA in which case it's likely to be positive earth although swapping over isn't an issue.
I would buy some wire of the correct colours and rewire it. An easy afternoon's work. Trying to deal with previously bodged wiring is a nightmare.
Here's an example diagram: