Hi,
Classic bike shop
?
It never ceases to amaze me the butchery people get up to
To strip and assembly your forks you need a tool like this,
http://www.ebay.co.uk/itm/61-3005-BSA-FORK-SEAL-HOLDER-TOOL-A7-A10-A50-A65-B31-B32-B33-B34-B40-B44-M20-M21-/201854605772?hash=item2eff78d9cc:g:ZB4AAOSw9mFWI7PEFind the BSA fork service sheets online for instructions,
I have found a problem with recently supplied fork bushes in that they are chamfered on the top outer edge
This means the bushes are not clamped tight when the circlips are fitted
A way around this is to machine the top of the bush and fit a suitable thickness shim to restore the fit
If the bushes are left with movement then you get an annoying hammering as the forks work
Shim packets are available from the suppliers of the fork bushes etc
The replacement fork leg you got is from a unit bike from the 60's, they had a rod damper setup
You need to get a matching leg and the rod dampers to get these to work
or an original 58 leg
HTH
John